chore: retire BOPS v1 submission endpoints and events #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
reviewed
Mar 6, 2024
DafyddLlyr
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Testing notes
- Go through a submission service & confirm a single BOPS event is created on Send
- Repeat using Invite to Pay (you'll have to successfully complete mock payment)
- Confirm that submission succeeds (valid digital planning payload and audit table entry)
All working as expected ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the go ahead from BOPS to stop sending parallel application payloads and only submit via their v2 endpoint.
Changes here:
/send/bopsendpoint is removed, and/send/bops-v2is renamed to/send/bopsfor simplicity/admin/session/:sessionId/bopsendpoint is removed (we use existing/admin/session/:sessionId/digital-planning-applicationendpoint to inspect v2 payload)I'll open a followup PR to additionally clean up planx-core, but this one can merge anytime before that as we're no longer calling
$api.export.bopsPayload(sessionId)& v1 submissions are already failing on file tag validation.Testing: