Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Remove redundant hidden text #2861

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(a11y): Remove redundant hidden text #2861

merged 1 commit into from
Mar 6, 2024

Conversation

DafyddLlyr
Copy link
Contributor

What does this PR do?

  • Addresses issue DAC_Hidden_Text_01 in Accessability Report
  • Removes redundant FormHelperText component

Why is removing this the solution?

  • The description is already present and reachable by screen-readers
  • The markdown is actually wrong - rather than reference the id DESCRIPTION_TEXT, it's referencing the meaningless string description-text directly
image

@DafyddLlyr DafyddLlyr requested a review from a team March 6, 2024 11:44
@DafyddLlyr
Copy link
Contributor Author

Hidden text [A]

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 3cfab7d into main Mar 6, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/redundant-visually-hidden-text branch March 6, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s