Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Update default description in Pay component #2862

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix(a11y): Update default description in Pay component #2862

merged 1 commit into from
Mar 7, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Mar 6, 2024 •
edited
Loading

What does this PR do?

  • Addresses issue DAC_Link_Purpose_Out_of_Context_01 in Accessibility Report (page 63)
  • Updates default description for Pay component (content taken from template - this is consistent across services)
  • Updated content of flow where this issue was flagged - https://editor.planx.uk/lambeth/accessibility-test
    • Not yet published, will check on OSL Slack before proceeding
  • Manually checked current submission services for out-of-date content, no issues found (will cross-check on OSL Slack)

image

@DafyddLlyr
Copy link
Contributor Author

Link purpose out of context [AAA]

@DafyddLlyr DafyddLlyr force-pushed the dp/update-pay-default-description branch from c934110 to 25bb5f3 Compare March 6, 2024 12:17
@DafyddLlyr DafyddLlyr marked this pull request as ready for review March 6, 2024 13:44
@DafyddLlyr DafyddLlyr requested a review from a team March 6, 2024 13:44
@DafyddLlyr DafyddLlyr changed the title fix(a11y): Update default description in Pay component [skip pizza] fix(a11y): Update default description in Pay component Mar 6, 2024
@DafyddLlyr DafyddLlyr merged commit d307269 into main Mar 7, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/update-pay-default-description branch March 7, 2024 08:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Removed vultr server and associated DNS entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak