Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update v1 bops mocks in e2e regression tests #2872

Merged
merged 5 commits into from
Mar 26, 2024
+3 −6
Merged

fix: update v1 bops mocks in e2e regression tests #2872

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66f09fa
update bops mock
jessicamcinchak Mar 7, 2024
7141ede
update e2e session to validate against ODP schema
jessicamcinchak Mar 7, 2024
53015ab
run prettier
jessicamcinchak Mar 7, 2024
9a43e06
Merge branch 'main' of github.com:theopensystemslab/planx-new into je…
jessicamcinchak Mar 8, 2024
07a446d
Merge branch 'main' of github.com:theopensystemslab/planx-new into je…
jessicamcinchak Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/tests/api-driven/src/invite-to-pay/mocks/server-mocks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# BOPS submissions
- request:
method: POST
path: /api/v1/planning_applications
path: /api/v2/planning_applications
response:
headers:
Content-Type: application/json
Expand Down
7 changes: 3 additions & 4 deletions e2e/tests/api-driven/src/invite-to-pay/mocks/session.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"designated.nationalPark",
"designated.nationalPark.broads",
"designated.WHS",
"designated.SPA",
"nature.SPA",
"monument",
"tpo",
"nature.SSSI",
Expand Down Expand Up @@ -55,8 +55,7 @@
"project.type": ["alter.equipment.solar.pv"],
"property.EPC": ["unknown"],
"property.type": [
"commercial.medical.dentist",
"alter.equipment.solar.pv"
"commercial.medical.dentist"
],
"proposal.time": ["future"],
"proposal.type": ["proposed"],
Expand Down Expand Up @@ -280,7 +279,7 @@
"designated.nationalPark",
"designated.nationalPark.broads",
"designated.WHS",
"designated.SPA",
Copy link
Member Author

@jessicamcinchak jessicamcinchak Mar 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This session mock data was originally generated on staging. I've updatd it's lowcal_session.data using these changes (even though post-sanitation) to confirm that it validates successfully against ODP schema (and therefore would be a valid BOPS v2 payload): https://api.editor.planx.dev/admin/session/d4d9249a-dc1e-4996-9bfc-15fd3adab242/digital-planning-application

"nature.SPA",
"monument",
"tpo",
"nature.SSSI",
Expand Down
Loading