Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand the application data exposed on submission_services_summary #2879

Merged

Conversation

Mike-Heneghan
Copy link
Contributor

What

  • Spun out of draft PR: feat: show submitted applications for a flow in the flow settings  #2867
  • Add submission_services_summary tracking
  • Expand the application data exposed in the view
  • Adding columns:
    • payment_request
    • payment_status
    • bops_applications
    • uniform_applications
    • email_applications
  • Each summarising related records as an array of objects with pertinent data

Why

@Mike-Heneghan Mike-Heneghan self-assigned this Mar 12, 2024
Copy link

🤖 Hasura Change Summary compared a subset of table metadata including permissions:

Tracked Tables (1)

  • public.submission_services_summary permissions:

    insert select update delete
    platformAdmin
    teamEditor
    34 added column permissions
    insert select update
    platformAdmin ➕ bops_applications
    ➕ created_at
    ➕ email_applications
    ➕ number_times_resumed
    ➕ payment_requests
    ➕ payment_status
    ➕ sent_to_bops
    ➕ sent_to_email
    ➕ sent_to_uniform
    ➕ service_slug
    ➕ session_id
    ➕ session_length_days
    ➕ submitted_at
    ➕ team_slug
    ➕ uniform_applications
    ➕ user_clicked_save
    ➕ user_invited_to_pay
    teamEditor

@Mike-Heneghan Mike-Heneghan marked this pull request as ready for review March 12, 2024 17:37
@Mike-Heneghan Mike-Heneghan requested a review from a team March 12, 2024 17:37
Copy link

github-actions bot commented Mar 12, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice job incorporating the new many-to-one array columns while maintaining the rest of the previous structure so analytics shouldn't break 👍

@Mike-Heneghan Mike-Heneghan merged commit 666385f into main Mar 13, 2024
12 checks passed
@Mike-Heneghan Mike-Heneghan deleted the mh/expand-application-data-submission-services-summary branch March 13, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants