Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove GovPay env vars #2888

Merged
merged 4 commits into from
Mar 15, 2024
Merged

chore: Remove GovPay env vars #2888

merged 4 commits into from
Mar 15, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Mar 14, 2024

What does this PR do?

  • Removes GovPay env vars, as values are now being read from team_integrations table
  • Follow up to feat: Read GovPay tokens from team_integrations table #2790
  • Please note - .env files on S3 not yet updated - no rush to do this, as it could break open (non-rebased) Pizzas. I'll pick this up as a follow on task a few days after this PR merges

To Do (before merging)

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these shrinking env files ✂️ so much friendlier for forks & non-OSL onboarding!

Copy link

github-actions bot commented Mar 14, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit 865691e into main Mar 15, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-govpay-env-vars branch March 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants