Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop redundant @testing-library/dom dependency #2904

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Mar 15, 2024

Something small I noticed when working on tests for #2878 - this package isn't required, and can cause issues if it resolves to a different version.

If you use one of the framework wrappers, it is important that @testing-library/dom is resolved to the same installation required by the framework wrapper of your choice.

Usually this means that if you use one of the framework wrappers, you should not add @testing-library/dom to your project dependencies.

Source: https://testing-library.com/docs/user-event/install/

Copy link

github-actions bot commented Mar 15, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/drop-testing-library-dom branch from 9bb9a77 to b2652c1 Compare March 15, 2024 17:20
@DafyddLlyr DafyddLlyr marked this pull request as ready for review March 15, 2024 17:31
@DafyddLlyr DafyddLlyr requested a review from a team March 15, 2024 17:31
@DafyddLlyr DafyddLlyr merged commit a2af237 into main Mar 15, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-testing-library-dom branch March 15, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants