Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SubmissionsTable to SubmissionsView #2905

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Mike-Heneghan
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan commented Mar 15, 2024

What

  • Follow on from: feat: SubmissionsTable component #2898
  • Add the SubmissionsTable to the SubmissionsView to render it when there's submission data
  • Add basic stories for component sates
  • Add basic tests

Why

  • Incremental step towards feature

@Mike-Heneghan Mike-Heneghan requested a review from a team March 15, 2024 16:57
@Mike-Heneghan Mike-Heneghan self-assigned this Mar 15, 2024
Copy link

github-actions bot commented Mar 15, 2024

Removed vultr server and associated DNS entries

import { mockApplications } from "./mocks";
import SubmissionsView from "./SubmissionsView";

describe("SubmissionsView Component", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this! 👍

@Mike-Heneghan Mike-Heneghan changed the base branch from mh/submissions-table to main March 25, 2024 10:08
- Render the SubmissionsTable if there are applications
- Add basic stories for each component state
- Add basic testing
@Mike-Heneghan Mike-Heneghan force-pushed the mh/submissions-view-story-and-testing branch from 799ea09 to 06a083f Compare March 25, 2024 10:21
@Mike-Heneghan Mike-Heneghan merged commit 79f0b3d into main Mar 25, 2024
12 checks passed
@Mike-Heneghan Mike-Heneghan deleted the mh/submissions-view-story-and-testing branch March 25, 2024 10:50
@Mike-Heneghan Mike-Heneghan restored the mh/submissions-view-story-and-testing branch March 25, 2024 10:55
@Mike-Heneghan
Copy link
Contributor Author

@Mike-Heneghan Mike-Heneghan deleted the mh/submissions-view-story-and-testing branch April 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants