Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump planx-core including ODP Schema v0.4.1 #2906

Closed
wants to merge 1 commit into from

Conversation

jessicamcinchak
Copy link
Member

Would love to get this on staging today as I offered to do a staging re-submit for Freya that was invalid because of a missing file type yesterday: https://opendigitalplanning.slack.com/archives/C0241GWFG4B/p1710434142767489

@Mike-Heneghan
Copy link
Contributor

I think the the change made to the Session here: https://github.com/theopensystemslab/planx-core/pull/328/files is leading to the failing tests as the changes aren't reflected in this repo?

Error: modules/pay/service/inviteToPay/createPaymentSendEvents.ts(44,72): error TS2551: Property 'flowId' does not exist on type 'Session'. Did you mean 'flow'?

@jessicamcinchak jessicamcinchak marked this pull request as draft March 15, 2024 17:19
@jessicamcinchak
Copy link
Member Author

Yes thanks @Mike-Heneghan - started fixing this type bug over here #2893 earlier, and just testing a latest attempt now theopensystemslab/planx-core#329

Converted this to draft in meantime, sorry for confusion!

@jessicamcinchak
Copy link
Member Author

Can close this in favor of #2893 which is now on the latest version of planx-core including ODP Schema v0.4.1 !

@jessicamcinchak jessicamcinchak deleted the jess/odp-schema-v0.4.1 branch March 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants