Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test coverage for index.tsx as well as stories #2910

Merged
merged 2 commits into from
Mar 25, 2024
Merged

test: add test coverage for index.tsx as well as stories #2910

merged 2 commits into from
Mar 25, 2024

Conversation

Mike-Heneghan
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan commented Mar 15, 2024 •
edited
Loading

What

  • Add basic tests dependent on potential query results
  • Add basic storybook stories based on query results

Why

  • Improve test coverage
  • Add to component library on. storybook

@Mike-Heneghan Mike-Heneghan self-assigned this Mar 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@Mike-Heneghan Mike-Heneghan force-pushed the mh/submissions-view-story-and-testing branch from 799ea09 to 06a083f Compare March 25, 2024 10:21
Base automatically changed from mh/submissions-view-story-and-testing to main March 25, 2024 10:50
@Mike-Heneghan
test: add test coverage for index.tsx
c02497e 
- Adds basic tests dependent on potential query results
@Mike-Heneghan Mike-Heneghan force-pushed the mh/submissions-story-and-testing branch from 4c1a93f to c02497e Compare March 25, 2024 10:56
@Mike-Heneghan Mike-Heneghan changed the title test: add test coverage for index.tsx test: add test coverage for index.tsx as well as stories Mar 25, 2024
@Mike-Heneghan Mike-Heneghan marked this pull request as ready for review March 25, 2024 11:47
@Mike-Heneghan Mike-Heneghan requested a review from a team March 25, 2024 11:47
@Mike-Heneghan
Copy link
Contributor Author

Allow service owners and product owners to see that an application has been sent successfully

DafyddLlyr
DafyddLlyr approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@Mike-Heneghan Mike-Heneghan merged commit d98f07c into main Mar 25, 2024
12 checks passed
@Mike-Heneghan Mike-Heneghan deleted the mh/submissions-story-and-testing branch April 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees

@Mike-Heneghan Mike-Heneghan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mike-Heneghan @DafyddLlyr