feat: Append, replace, removeOne, & removeAll operations for SetValue
#2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/set-value-v2
branch
from
1432489 to
de31065
Compare
DafyddLlyr
commented
Mar 21, 2024
DafyddLlyr
changed the title
SetValueSetValue
editor.planx.uk/src/pages/FlowEditor/components/Flow/components/Node.tsx
Show resolved
Hide resolved
DafyddLlyr
force-pushed
the
dp/set-value-v2
branch
from
367fd74 to
80abf01
Compare
- Useful for tests!
DafyddLlyr
force-pushed
the
dp/set-value-v2
branch
from
580f985 to
ff7f22e
Compare
DafyddLlyr
force-pushed
the
dp/set-value-v2
branch
2 times, most recently
from
5e1ae08 to
3d0c6e2
Compare
DafyddLlyr
force-pushed
the
dp/set-value-v2
branch
from
3d0c6e2 to
8894929
Compare
DafyddLlyr
commented
May 3, 2024
There was a problem hiding this comment.
This file should represent the inputs/outputs described in this "Logic Camp" diagram -
Source: https://miro.com/app/board/uXjVN9K07PQ=/?moveToWidget=3458764578921902831&cot=14
DafyddLlyr
changed the title
SetValueSetValue
DafyddLlyr
commented
May 6, 2024
| * Handle modifying passport values when passing through a SetValue component | ||
| * Called by computePassport() | ||
| */ | ||
| export const handleSetValue: HandleSetValue = ({ |
There was a problem hiding this comment.
Following previous conversations, I've refactored this logic to be co-located with the component rather than being purely within the store.
The motivations here were two-fold -
- This is SetValue logic and doesn't relate to any other components - it just can't get called by this component directly
- We actually want to use some of this code within the Editor modal to show the Editor examples of how this component works (upcoming PR). Locating this within the store would make this harder to re-use in a different context.
jessicamcinchak
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Testing
Basic test flow here - https://2914.planx.pizza/testing/set-value-playground
This (hopefully!) illustrates that the behaviour matches the desired outcomes discussion at our recent "Logic Camp" - full details here - https://miro.com/app/board/uXjVN9K07PQ=/?moveToWidget=3458764588027715730&cot=14
I feel like there's a decent level of unit testing here, as well as more psuedo-integration level tests calling store functions to mock a user's journey.
What I'm really interested in testing feedback on would be -
Next steps...