chore: Add Gateshead chain certificate, update docs for PKCS #7 #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
approved these changes
Mar 28, 2024
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent production deploy failed with the following error -
aws:cloudfront:Distribution (planningservices.gateshead.gov.uk-cdn): error: 1 error occurred: * creating CloudFront Distribution: InvalidViewerCertificate: The certificate that is attached to your distribution was not issued by a trusted Certificate Authority. For more details, see: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/CNAMEs.html#alternate-domain-names-requirements status code: 400, request id: 03686aca-301f-409d-9262-42ebad2767e0This indicates that a chain certificate is required. Gateshead supplied a
.pemwithout chain/root certificate as well as a.p7bwhich did include the chain certificates. Both passed the manual tests we use on AWS without issue - the failure is only picked up when the certificates are actually deployed to a distribution it seems.I think the lesson is - if chain certs are sent across, we should always require them. I've added an explicit comment to this effect in the docs.