fix(a11y): ResultReason tabindex order
#2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is just matching the default behaviour of the MUI accordion
|
Removed vultr server and associated DNS entries |
DafyddLlyr
changed the title
ResultReason tabindex order
ianjon3s
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
This is a really strong solution. I had attempted to reorder the components as a quick solution and had identified the need to inherit the height to prevent the chevron shifting on expand. In the jQuery days this would be injected after the html render (not ideal), good to see the powers of React rendering used here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
useRef()anduseLayoutEffect()hooks to maintain consistent style - change button remains in same locationDemo
Screen.Recording.2024-03-28.at.16.29.07.mov
🧪 Test flow: https://2941.planx.pizza/testing/result-tab-index-order/amber
Also...
There were a few lines controlling the logic around
expandedandonChangewhich are redundant - the MUI accordion has this as the default behaviour anyway, so I've removed this.