-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Replace Collapse
and Button
with Accordion
components in PlanningConstraints
#2966
fix(a11y): Replace Collapse
and Button
with Accordion
components in PlanningConstraints
#2966
Conversation
shouldForwardProp: (prop) => prop !== "category", | ||
})<StyledConstraintProps>(({ theme, category }) => ({ | ||
const StyledAccordion = styled(Accordion, { | ||
shouldForwardProp: (prop) => !["category", "metadata", "content", "data"].includes(prop as string), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments on the diffs relating to ID usage and styling parity.
Really good to see this updated to the appropriate accordion component!
editor.planx.uk/src/@planx/components/PlanningConstraints/List.tsx
Outdated
Show resolved
Hide resolved
editor.planx.uk/src/@planx/components/PlanningConstraints/List.tsx
Outdated
Show resolved
Hide resolved
5218c64
into
dp/planning-constrains-multiple-lists
What does this PR do?
Button
andCollapse
components with anAccordion
componentResultReason
)Button
.Motivation
expanded
,aria-controls
)