Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): collapse map attributions and wrap SummaryList columns on small screens #2969

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Apr 2, 2024

From page 61:

Content is lost when resizing the webpage to a smaller viewing dimension. This instance can
be found with the site boundary section of the definition list. The map feature has been
resized however the tooltip provided is covering the user from identifying the boundary of
the location. This issue affects low vision users who are likely to require a smaller window to
progress through the journey as content is affected.
Additionally, due to the change links being covered on the side of the window, part of the
focus highlight is obscured.

Changes:

  • Openlayers map attributions are collapsed on screens less than 500px
  • Review page SummaryList 3-column layout is collapsed to single column on screens less than 500px ("small" MUI breakpoint), consistent with GOV.UK component behavior

Screenshot from 2024-04-02 13-19-28

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak marked this pull request as ready for review April 2, 2024 11:56
@jessicamcinchak jessicamcinchak requested a review from a team April 2, 2024 11:56
Copy link

github-actions bot commented Apr 2, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice and simple 👌

@jessicamcinchak jessicamcinchak merged commit c365eae into main Apr 2, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/summary-list-overflow branch April 2, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants