Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move back button out of main component, ensure single main component only #2970

Merged
merged 5 commits into from
Apr 4, 2024
Merged

feat: Move back button out of main component, ensure single main component only #2970

merged 5 commits into from
Apr 4, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 2, 2024 •
edited
Loading

What does this PR do?

  • Move back component out of #main element (report page 91 - Trello ticket)
  • Ensure we only use a single #main element (report page 82 - Trello ticket)
  • Use <main> element instead of <div role="main"> - not in report just something I spotted. From MDN docs -

Prefer using the <main> element over declaring role="main", unless there are legacy browser support concerns.

@DafyddLlyr
Copy link
Contributor Author

Back button positioning [Usability]

@DafyddLlyr
Copy link
Contributor Author

Multiple main roles [Usability]

@DafyddLlyr DafyddLlyr requested a review from a team April 2, 2024 11:42
@DafyddLlyr DafyddLlyr marked this pull request as ready for review April 2, 2024 11:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/main-back-main branch 2 times, most recently from 994498d to b2f3823 Compare April 2, 2024 14:41
Mike-Heneghan
Mike-Heneghan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and working as expected for me 🥳

@DafyddLlyr DafyddLlyr merged commit 5f0c122 into main Apr 4, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/main-back-main branch April 4, 2024 09:03
@DafyddLlyr DafyddLlyr mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Heneghan Mike-Heneghan Mike-Heneghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @Mike-Heneghan