Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): FileUploadAndLabel error messages #2973

Merged
merged 3 commits into from
Apr 3, 2024
Merged

fix(a11y): FileUploadAndLabel error messages #2973

merged 3 commits into from
Apr 3, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 3, 2024 •
edited
Loading

What does this PR do?

  • Displays an error per-unlabeled file in both modal and public component

Context

From accessibility report, page 39 -

An error caused by not applying any tags to a document are not easily identifiable through use of the error text. This instance can be found when not including tags to uploaded documents. The error that appears has been placed above the done button, without a status message, and does not relate to the input to which the error has been caused by. This issue affects screen reader users as the error message does not immediately explain what is wrong, not does it highlight the input relating to the issue.

The "alert" role is added in this PR - #2974

Demo

Per-file error messages in modal
image

Per-file error message in Public component
image

Validation for whole list still in place
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/a11y-errors-fual branch from cfb3f30 to 92dbc76 Compare April 3, 2024 07:02
@DafyddLlyr DafyddLlyr requested a review from a team April 3, 2024 07:03
@DafyddLlyr DafyddLlyr marked this pull request as ready for review April 3, 2024 07:09
Mike-Heneghan
Mike-Heneghan approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, seems like a really useful change 🥳

@DafyddLlyr DafyddLlyr merged commit 5b642e6 into main Apr 3, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/a11y-errors-fual branch April 3, 2024 11:28
@DafyddLlyr
Copy link
Contributor Author

Error identification for Upload&Label [A]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Heneghan Mike-Heneghan Mike-Heneghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @Mike-Heneghan