Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Styling for submissions table #2975

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Conversation

ianjon3s
Copy link
Contributor

@ianjon3s ianjon3s commented Apr 3, 2024

What does this PR do?

Adds a basic level of styling to the submissions log table:

  • Page containers adjusted to allow full width or 'form' width containers.
  • Table given max-height to allow for sticky headers — this is a quirk with HTML tables in that they cannot have sticky headers and horizontal overflow scroll without an explicit height or max-height being set.
  • Other settings pages updated to use same <EditorRow> component for consistency.

There is no data in the pizza environment but the table can be previewed on Storybook (thanks for @Mike-Heneghan for putting together the stories for this!):

https://storybook.2975.planx.pizza/?path=/docs/design-system-molecules-submissions--docs

Note: Storybook does squash up the columns somewhat, it'll be a lot more readable in the editor.

(currently behind a feature flag on production: window.featureFlags.toggle("SUBMISSION_VIEW"))

Copy link

github-actions bot commented Apr 3, 2024

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s marked this pull request as ready for review April 3, 2024 12:14
@ianjon3s ianjon3s requested a review from a team April 3, 2024 12:15
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🙌

The width, sticky headers and visual contrast makes this so much more usable 🥳

@ianjon3s ianjon3s merged commit 708ac8d into main Apr 3, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/submission-details-styling branch April 3, 2024 13:45
@DafyddLlyr
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants