Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop SUBMISSION_VIEW feature flag #2977

Merged
merged 1 commit into from
Apr 4, 2024
Merged

chore: Drop SUBMISSION_VIEW feature flag #2977

merged 1 commit into from
Apr 4, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 4, 2024 •
edited
Loading

What does this PR do?

  • Drop feature flag to create Pizza for UAT
  • Some type tidy ups

In this instance we’re better off removing the feature flag and encouraging PO testing on production as -

  • there’s real submission data there to test against
  • it’s a pretty unobtrusive feature - if it needs changes we can easily do this without effecting anything else

@DafyddLlyr DafyddLlyr added the UAT (User Agent Testing) actively being tested before deployment label Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team April 4, 2024 07:40
@DafyddLlyr
Copy link
Contributor Author

Allow servicer owners and product owners to to see than an application has been sent successfully

@DafyddLlyr DafyddLlyr removed the UAT (User Agent Testing) actively being tested before deployment label Apr 4, 2024
Mike-Heneghan
Mike-Heneghan approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@Mike-Heneghan Mike-Heneghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@DafyddLlyr DafyddLlyr merged commit 47eb95f into main Apr 4, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-submissions-view-ff branch April 4, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Heneghan Mike-Heneghan Mike-Heneghan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @Mike-Heneghan