Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): enforce positive numbers by default on NumberInput #2982

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(a11y): enforce positive numbers by default on NumberInput #2982

merged 1 commit into from
Apr 4, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Apr 4, 2024 •
edited
Loading

From page 84:

An input accepts negative numbers where it shouldn’t be possible.

Solution:
We suggest implementing an error message similarly to how other errors have been
implemented for the negative values.

Changes:

  • NumberInput now expects positive numbers by default & shows a specific error message when not valid (will flag this to George & August as any legitimate negative inputs will need to be updated after deploy)
  • Adds an Editor toggle to "Allow negative numbers" which is "off" by default

Screenshot from 2024-04-04 13-58-33

Screenshot from 2024-04-04 13-58-48

@jessicamcinchak
Copy link
Member Author

Negative numbers [Usability]

@jessicamcinchak jessicamcinchak requested a review from a team April 4, 2024 12:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

DafyddLlyr
DafyddLlyr approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌

@jessicamcinchak jessicamcinchak merged commit 6225ced into main Apr 4, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/numberinput-error-negatives branch April 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr