refactor: create trackEvent function and apply updates in relevant files #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mike-Heneghan
force-pushed
the
mh/consolidate-tracking-events
branch
from
14d36d4 to
042e2a3
Compare
Mike-Heneghan
changed the base branch from
mh/move-analytics-mutations-into-file
to
main
- As per: #2597 (comment) - Consolidating individual tracking event functions into a single function with a case statement - Step towards clearer organisation and documentation of analyticsProvider Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
Mike-Heneghan
force-pushed
the
mh/consolidate-tracking-events
branch
from
042e2a3 to
5f30620
Compare
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Apr 5, 2024
| trackNextStepsLinkClick: () => Promise.resolve(), | ||
| trackFlowDirectionChange: () => Promise.resolve(), | ||
| trackBackwardsNavigation: () => Promise.resolve(), | ||
| trackEvent: () => Promise.resolve(), |
There was a problem hiding this comment.
Much neater and cleaner 💪
| async function trackHelpClick(metadata?: HelpClickMetadata) { | ||
| if (shouldSkipTracking()) return; | ||
|
|
||
| async function updateMetadata(mutation: any, metadata: Metadata) { |
There was a problem hiding this comment.
Suggested change
| async function updateMetadata(mutation: any, metadata: Metadata) { | |
| async function updateMetadata(mutation: DocumentNode, metadata: Metadata) { |
I think this is right - this should be the type of strings wrapped in gql tags.
There was a problem hiding this comment.
Thanks for spotting this @DafyddLlyr, I did the classic "I'll come back to this later and totally forgot 😅" should be fixed here: a7ac3b1
| }; | ||
|
|
||
| /** | ||
| * The flow direction when a new analytics session is create is |
There was a problem hiding this comment.
Suggested change
| * The flow direction when a new analytics session is create is | |
| * The flow direction when a new analytics session is created is |
There was a problem hiding this comment.
Should be fixed here: f811fe2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why