Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hoist main element higher up DOM tree #2994

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix: Hoist main element higher up DOM tree #2994

merged 1 commit into from
Apr 8, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 8, 2024 •
edited
Loading

What does this PR do?

  • Moves the main element as high up the component tree as we can, to ensure all views are wrapped
  • We've had to recently move this "down" so as to not wrap the "back" button for accessibility reasons, hence the need to repeat this a few places

✅ Regression tests passing against this branch here - https://github.com/theopensystemslab/planx-new/actions/runs/8595892001

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr requested a review from a team April 8, 2024 07:30
@DafyddLlyr DafyddLlyr marked this pull request as ready for review April 8, 2024 07:30
@DafyddLlyr DafyddLlyr merged commit 7eafaf2 into main Apr 8, 2024
17 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/hoist-main-content-higher-up-dom-tree branch April 8, 2024 08:30
@DafyddLlyr DafyddLlyr mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak