feat: add AWS S3 bucket as "Send" destination for staging envs only #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Apr 9, 2024
| value: Destination.S3, | ||
| label: "Upload to AWS S3 bucket", | ||
| }); | ||
| } |
There was a problem hiding this comment.
Rather than introduce a feature-flag here which we'll then have to communicate to Editors how to use - I figure we can just only display this option on non-prod environments at first? It also throws an alert with warning message if anyone outside of Barnet selects it.
There was a problem hiding this comment.
Yeah this works well I think 👍
jessicamcinchak
commented
Apr 9, 2024
| @@ -76,7 +84,8 @@ const SendComponent: React.FC<Props> = (props) => { | |||
|
|
|||
| // Show warnings on selection of BOPS or Uniform for likely unsupported services | |||
| // Don't actually restrict selection because flowSlug matching is imperfect for some valid test cases | |||
| const flowSlug = window.location.pathname?.split("/")?.[1]; | |||
| const teamSlug = window.location.pathname?.split("/")?.[1]; | |||
| const flowSlug = window.location.pathname?.split("/")?.[2]; | |||
There was a problem hiding this comment.
The flowSlug index was actually wrong here, but only impacted the in-editor warning messages - now fixed throughout!
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Apr 9, 2024
| value: Destination.S3, | ||
| label: "Upload to AWS S3 bucket", | ||
| }); | ||
| } |
There was a problem hiding this comment.
Yeah this works well I think 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editor-side changes for the Barnet prototype described in linked Trello ticket. API changes to follow in a separate PR