Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip Send event creation if not a published route #3013

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Apr 12, 2024

Should cut down on these cannot find session errors on Send endpoints!
Screenshot from 2024-04-12 10-45-33

Testing:

  • On a /draft or /amber route, the Send component shows the following error message - you can click through to proceed to a Confirmation page but no events will be created in Hasura
    Screenshot from 2024-04-12 10-40-04
  • On a /published route, the Send component queues up the applicable events and only shows a brief loading indicator just as before

@jessicamcinchak jessicamcinchak changed the title feat: skip Send event creation if not a published route fix: skip Send event creation if not a published route Apr 12, 2024
@jessicamcinchak jessicamcinchak requested a review from a team April 12, 2024 09:00
Copy link

github-actions bot commented Apr 12, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice solution 👌

@jessicamcinchak jessicamcinchak merged commit 194ccfd into main Apr 12, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/skip-send-events-non-published-routes branch April 12, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants