Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(a11y): Re-order dropzone to be above file cards #3016

Merged
merged 1 commit into from
Apr 12, 2024
Merged

chore(a11y): Re-order dropzone to be above file cards #3016

merged 1 commit into from
Apr 12, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 12, 2024 •
edited
Loading

What does this PR do?

  • Reorders the Dropzone component to be above the list of UploadedFileCard components

Why?

  • Recommended as a usability improvement in accessibility report - issue "Organisation of Content", page 80
  • Matches file upload and label
image

@DafyddLlyr DafyddLlyr requested a review from a team April 12, 2024 14:23
@DafyddLlyr DafyddLlyr marked this pull request as ready for review April 12, 2024 14:23
@DafyddLlyr DafyddLlyr changed the title chore: Re-order dropzone to be above file cards chore(a11y): Re-order dropzone to be above file cards Apr 12, 2024
@DafyddLlyr
Copy link
Contributor Author

Organisation of content [Usability]

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr merged commit e35f3b2 into main Apr 12, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/file-upload-card-order branch April 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianjon3s ianjon3s ianjon3s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @ianjon3s