feat: add option to skipValidation when using /digital-planning-application admin endpoint
#3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Perfect!
Now using https://json-schema.app/view/%23?url=https%3A%2F%2Ftheopensystemslab.github.io%2Fdigital-planning-data-schemas%2Fv0.5.0%2Fschema.json we can copy/paste the payload and get a readable and super clear list of validation errors right away 🥇
| let skipValidation = false; | ||
| if (req.query?.skipValidation) { | ||
| skipValidation = | ||
| (req.query.skipValidation as string).toLowerCase() === "true"; |
There was a problem hiding this comment.
Easy to forget this query param step when dealing with bools! 👌
jessicamcinchak
added a commit
to theopensystemslab/planx-core
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on theopensystemslab/planx-core#353
Testing:
skipValidationquery param now displays the invalid data payload https://api.3021.planx.pizza/admin/session/22d8d2ee-df1f-4696-9713-fc366561ee98/digital-planning-application?skipValidation=true