-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Restructure Editor sidebar #3057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/restructure-editor-sidebar
branch
2 times, most recently
from
May 3, 2024 17:46
9a511c1
to
594234c
Compare
Now that undo is merged I'll rebase this today and open for review. |
DafyddLlyr
force-pushed
the
dp/restructure-editor-sidebar
branch
from
May 17, 2024 11:18
594234c
to
080e6a6
Compare
jessicamcinchak
approved these changes
May 17, 2024
@@ -359,7 +359,7 @@ const AlteredNodesSummaryContent = (props: { | |||
); | |||
}; | |||
|
|||
const PreviewBrowser: React.FC<{ | |||
const Sidebar: React.FC<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is no small thing !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now that the right hand panel in the Editor can contain multiple tabs, we need to do some renaming / tidying up here.
Also - quick / easy work to pick up in the background of roadmap!
What does this PR do?
PreviewBrowser
→Sidebar
EditHistory
to it's own componentutils.ts
fileThis will inevatably conflict with #3056 sorry - super happy to park this PR until "undo" progresses, then I'll come back and rebase here. Keeping as a draft until then.