Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Restructure Editor sidebar #3057

Merged
merged 8 commits into from
May 17, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Apr 25, 2024

Context

Now that the right hand panel in the Editor can contain multiple tabs, we need to do some renaming / tidying up here.

Also - quick / easy work to pick up in the background of roadmap!

What does this PR do?

  • Rename PreviewBrowserSidebar
  • Group components into folders
  • Move EditHistory to it's own component
  • Move a few shared functions to a utils.ts file
  • There should be no visual changes here, just restructuring / renaming

This will inevatably conflict with #3056 sorry - super happy to park this PR until "undo" progresses, then I'll come back and rebase here. Keeping as a draft until then.

Copy link

github-actions bot commented Apr 25, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/restructure-editor-sidebar branch 2 times, most recently from 9a511c1 to 594234c Compare May 3, 2024 17:46
@DafyddLlyr
Copy link
Contributor Author

Now that undo is merged I'll rebase this today and open for review.

@DafyddLlyr DafyddLlyr force-pushed the dp/restructure-editor-sidebar branch from 594234c to 080e6a6 Compare May 17, 2024 11:18
@DafyddLlyr DafyddLlyr requested a review from a team May 17, 2024 11:20
@DafyddLlyr DafyddLlyr marked this pull request as ready for review May 17, 2024 11:20
@@ -359,7 +359,7 @@ const AlteredNodesSummaryContent = (props: {
);
};

const PreviewBrowser: React.FC<{
const Sidebar: React.FC<{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no small thing !!

@DafyddLlyr DafyddLlyr merged commit 5fbcefd into main May 17, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/restructure-editor-sidebar branch May 17, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants