Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Test inputmode="none" on mobile for Autocomplete #3071

Closed
wants to merge 1 commit into from
Closed

wip: Test inputmode="none" on mobile for Autocomplete #3071

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions editor.planx.uk/src/@planx/components/FileUploadAndLabel/SelectMultiple.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import Typography from "@mui/material/Typography";
import capitalize from "lodash/capitalize";
import React, { forwardRef, PropsWithChildren, useMemo, useState } from "react";
import { borderedFocusStyle } from "theme";
import Checkbox from "ui/shared/Checkbox";

import { FileUploadSlot } from "../FileUpload/Public";
import {
Expand All @@ -28,7 +29,6 @@ import {
removeSlots,
UserFile,
} from "./model";
import Checkbox from "ui/shared/Checkbox";

interface SelectMultipleProps {
uploadedFile: FileUploadSlot;
Expand Down Expand Up @@ -108,6 +108,7 @@ const renderInput: AutocompleteProps<
InputProps={{
...params.InputProps,
notched: false,
inputMode: "none",
}}
label="What does this file show?"
/>
Expand All @@ -123,7 +124,12 @@ const renderGroup: AutocompleteProps<
false,
"div"
>["renderGroup"] = ({ group, key, children }) => (
<List key={`group-${key}`} role="group" sx={{ paddingY: 0 }} aria-labelledby={`${group}-label`}>
<List
key={`group-${key}`}
role="group"
sx={{ paddingY: 0 }}
aria-labelledby={`${group}-label`}
>
<ListSubheader
id={`${group}-label`}
role="presentation"
Expand Down Expand Up @@ -156,7 +162,7 @@ const renderOption: AutocompleteProps<
data-testid="select-checkbox"
checked={selected}
inputProps={{
"aria-label": option.name
"aria-label": option.name,
}}
/>
<ListItemText sx={{ ml: 2 }}>{option.name}</ListItemText>
Expand Down
Loading