fix: <fieldset> element overflows
#3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/fieldset-overflow
branch
2 times, most recently
from
800ec8a to
bb7eac2
Compare
|
Removed vultr server and associated DNS entries |
jessicamcinchak
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the route of the problem causing the recent layout quirks we've been encountering.
Regression originally introduced here - #2976
It turns out
<fieldset>elements havemin-inline-size: min-contentapplied by default (MDN docs). This means that child content was overflowing and affecting layouts in a number of ways.Broken layout on staging
https://editor.planx.dev/opensystemslab/listed-building-consent-files
Screen.Recording.2024-04-30.at.09.40.15.mov
Fixed layout on pizza
https://3072.editor.planx.pizza/opensystemslab/listed-building-consent-files