Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup query and placeholder components for "Team members" page #3109

Merged
merged 2 commits into from
May 3, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented May 3, 2024

What does this PR do?

  • Makes new page /:team/members
  • Sets up query to get team members, and to group by role
  • No styling, no feature flags!
  • Ready for handover to @ianjon3s!

Would be good to have a handover here to talk about how routes, queries, and components are lining up here 👍

Questions

  • "Inactive" users have an email address of null - should they be grouped by this, or are they fine within their previous roles?
  • We can add sorting to the query if we want to, that should then carry over into the groupBy()

@DafyddLlyr DafyddLlyr requested a review from a team May 3, 2024 14:51
@DafyddLlyr
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr removed the request for review from a team May 3, 2024 14:52
@DafyddLlyr DafyddLlyr marked this pull request as draft May 3, 2024 14:52
Copy link

github-actions bot commented May 3, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr marked this pull request as ready for review May 3, 2024 16:24
@DafyddLlyr DafyddLlyr requested a review from a team May 3, 2024 16:24
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great ! I think users with null email make sense to group by their previous roles, then would simply be greyed out or similar in the UI to signal "inactive". Sorting by first name within each role at the query role feels like an easy win 🙂

@DafyddLlyr
Copy link
Contributor Author

then would simply be greyed out or similar in the UI to signal "inactive".

My thoughts exactly!

Added sorting by first name and hidden (commented out) menu item until UI built so this can merge 👍

@DafyddLlyr DafyddLlyr merged commit f047472 into main May 3, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/my-team-query branch May 3, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants