feat: build pizzas on alpine #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
scripts/pullrequest/create.sh
Outdated
| # set env for this shell | ||
| set -o allexport | ||
| source .env.pizza | ||
| DOCKER_BUILDKIT=1 | ||
| set +o allexport | ||
|
|
||
| # start services | ||
| docker compose \ | ||
| time docker compose \ |
There was a problem hiding this comment.
👀 👀 ~3 minutes faster ?! looking promising 🤞 🏁
There was a problem hiding this comment.
@jessicamcinchak yes it is isn't it! now that the action is finalised I'm going to run a quick experiment with 5 PRs on each side, and see if this holds across a wider sample.
freemvmt
force-pushed
the
test-vultr-action-v2
branch
from
387c2a7 to
629e44a
Compare
freemvmt
force-pushed
the
build-pizzas-on-alpine
branch
from
b25f2b4 to
cd8c876
Compare
freemvmt
force-pushed
the
test-vultr-action-v2
branch
from
629e44a to
77fef3e
Compare
freemvmt
force-pushed
the
build-pizzas-on-alpine
branch
from
cd8c876 to
30ef4df
Compare
freemvmt
force-pushed
the
build-pizzas-on-alpine
branch
2 times, most recently
from
fae86c1 to
6e096aa
Compare
…cript for Alpine OS (instead of Ubuntu)
freemvmt
force-pushed
the
build-pizzas-on-alpine
branch
from
6e096aa to
fd9722b
Compare
jessicamcinchak
approved these changes
May 9, 2024
| $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list > /dev/null | ||
| apt-get update -y | ||
| apt-get install docker-ce docker-ce-cli containerd.io docker-compose-plugin -y | ||
|
|
jessicamcinchak
added a commit
that referenced
this pull request
May 24, 2024
This reverts commit ab444b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title - use Alpine OS instead of Ubuntu 22.04 as the base OS for our Vultr pizzas. This seems to provide some substantial time savings, according to some tests I ran (see below). In particular, the work of updating the server, ensuring docker and aws-cli are installed, and actually doing the
docker composecommand to build the container stack, all of which are encapsulated in theCreate commandsstep, is reduced from an average of 10:42 to 8:05, a saving of157s!I didn't compare the
Update commandsstep across the different operating systems, but there may also be gains there (I think unlikely that there would be losses).Note that Vultr now provides an OS for the new Ubuntu LTS release (24.04, Noble Numbat). This is only just released as of this PR. Once it's more mature (e.g. at least 24.04.1 is released), it may in turn provide benefits compared to Alpine (or not). We can test that theory at a later date.
Alpine
Ubuntu 22.04