Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): DrawBoundary link to switch between map and upload should always be enabled #3131

Merged
merged 3 commits into from
May 9, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented May 9, 2024

Previously:

  • We disabled the "Upload a location plan instead" and "Draw the boundary on a map instead" links to switch pages if the data on the respective page was fulfilled - meaning the user had to erase the boundary or remove their upload to switch pages back

Now:

  • The links to switch pages are always enabled regardless of data
  • Data is retained when switching pages
  • handleSubmit() only submits the data from the page which the use "Continues" onwards from - ensuring the application payload has GeoJSON or an uploaded location plan, never both

Screenshot from 2024-05-09 12-44-51

Note:

  • Enabling the link & updating the corresponding visuallyHidden text should fix the A-level issue described on page 17 (enabling by default also resolves a AA contrast issue)
  • The overall "Continue" button on this component is still conditionally enabled (similar to FindProperty). As I understand, this is a usability-level issue only and we can address separately in a follow-up PR (see work started in fix(a11y): continue button should always be enabled on FindProperty & DrawBoundary #3022)

Copy link

github-actions bot commented May 9, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak marked this pull request as ready for review May 9, 2024 11:02
@jessicamcinchak jessicamcinchak requested a review from a team May 9, 2024 11:02
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as expected.

@jessicamcinchak jessicamcinchak merged commit 2d8c65b into main May 9, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/a11y-drawboundary-page-links branch May 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants