-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): always enable continue button on FindProperty map page #3141
Conversation
Removed vultr server and associated DNS entries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very small comment, working as expected on Pizza. Thanks for detailed PR description and breaking this one up 👍
: Boolean(address) && !isValidating | ||
} | ||
> | ||
{getBody()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This was a bit unexpected - it should really be a React.FC
, e.g. <Body/>
(or some other name).
I know this isn't introduced here so it can be ignored or fixed forward as you feel best - same applies to DrawBoundary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noting this - will fix forward in this case to not over-complicate dependent PR right now !
Breaking these changes up by "page" as this one is quite tricky! This covers the FindProperty map page, and I'll address FindProperty's select page in a follow-up final PR to complete this attached ticket.
Changes:
validateAndSubmit
when clicking continueaddress
state)