Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): always enable continue button on FindProperty map page #3141

Merged
merged 1 commit into from
May 14, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented May 13, 2024

Breaking these changes up by "page" as this one is quite tricky! This covers the FindProperty map page, and I'll address FindProperty's select page in a follow-up final PR to complete this attached ticket.

Changes:

  • Continue is always enabled on FindProperty's "my site does not have an address" page (make sure editor component is configured to show page rather than external dialog), but you can only continue after placing a point and describing your site
  • Previously only the input had an error wrapper, now the map does as well
  • Both errors can be triggered via validateAndSubmit when clicking continue
  • Data is retained when clicking back (note that unlike DrawBoundary, data is cleared and NOT retained when switching pages in the case of FindProperty because either page sets the same address state)

Screenshot from 2024-05-13 15-48-56

@jessicamcinchak
Copy link
Member Author

@jessicamcinchak jessicamcinchak marked this pull request as ready for review May 13, 2024 14:44
@jessicamcinchak jessicamcinchak requested a review from a team May 13, 2024 14:44
Copy link

github-actions bot commented May 13, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very small comment, working as expected on Pizza. Thanks for detailed PR description and breaking this one up 👍

: Boolean(address) && !isValidating
}
>
{getBody()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This was a bit unexpected - it should really be a React.FC, e.g. <Body/> (or some other name).

I know this isn't introduced here so it can be ignored or fixed forward as you feel best - same applies to DrawBoundary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting this - will fix forward in this case to not over-complicate dependent PR right now !

@jessicamcinchak jessicamcinchak merged commit 711553c into main May 14, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/find-property-map-enable-continue branch May 14, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants