feat(a11y): Remove disabled button from Question component
#3149
Conversation
DafyddLlyr
changed the title
Question component
|
Removed vultr server and associated DNS entries |
- Add validation for `a` - Get test functions from `setup()` - Add `describe()` blocks
| validationSchema: object({ | ||
| selected: object({ | ||
| id: string().required("Select your answer before continuing"), | ||
| a: mixed().required().test(value => |
There was a problem hiding this comment.
selected.a can be undefined in initialValues - is it actually required here or optional?
Also nice to see the mixed() syntax in action 💪
There was a problem hiding this comment.
Good question! I think what I have is correct, as this is a required value at time of submission.
When the component loads the value is not set as it doesn't exist (so it's optional in the props). When navigating "back" it will be set already. The value for selected.a is set alongside selected.id here -
planx-new/editor.planx.uk/src/@planx/components/Question/Public/Question.tsx
Lines 115 to 116 in 6193731
There was a problem hiding this comment.
That distinction makes sense - thanks for clarifying!
| container | ||
| spacing={layout === QuestionLayout.Basic ? 0 : 2} | ||
| alignItems="stretch" | ||
| <ErrorWrapper id={`${props.id}-error`} error={formik.errors.selected?.id}> |
There was a problem hiding this comment.
nit: the ErrorWrapper component already prepends error-message- to whatever id is set here, so no need to explicitly use -error suffix as you have
What does this PR do?
QuestioncomponentsTest flow here with all variants of the question component - https://3149.planx.pizza/testing/question-error-test