Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Feedback sync script (example) #3160

Merged
merged 1 commit into from
May 17, 2024

Conversation

DafyddLlyr
Copy link
Contributor

Not really advocating for this to be merged, but I wanted some sort of history here and it may prove to be helpful for others.

I added a feedback.sql so I could get a copy of production data locally.

Commenting out an item in the list seemed a nicer pattern than a flag per table or some other optional inputs to the script. A bit quick and dirty but worked well for me.

@DafyddLlyr DafyddLlyr requested a review from a team May 17, 2024 10:34
@DafyddLlyr DafyddLlyr marked this pull request as ready for review May 17, 2024 10:34
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice example to have!

Was definitely thinking about this recently with undo (syncing operations) and submissions (syncing events tables in hdb_catalog schema) - and instead just lost a bit of time to creating them the old fashioned way 👍

team_themes
# Optional tables
# Please comment in if working on a feature and you require example data locally
# You will need to manually grant select permissions to the github_actions on production, and update main.sql
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DafyddLlyr
Copy link
Contributor Author

DafyddLlyr commented May 17, 2024

The operation example is actually a good one and a second use for this type of thing. I'll actually go ahead and merge - if it feels excessive or noisy in future we can move to docs or an alternate script or something in future.

@DafyddLlyr DafyddLlyr merged commit a477ea4 into main May 17, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/feedback-table-sync-example branch May 17, 2024 11:23
Copy link

Removed vultr server and associated DNS entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants