Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Position of address loading with save and return #3165

Merged
merged 1 commit into from
May 17, 2024

Conversation

ianjon3s
Copy link
Contributor

What does this PR do?

The updated loading indicator for address lookup is positioned absolute with a unit reference to bottom. This fails on when save & return is enabled as the button is no longer the last element in the container.

This PR adjusts so that the indicator is positioned with reference to the top of the container.

@ianjon3s ianjon3s requested a review from a team May 17, 2024 14:24
Copy link

github-actions bot commented May 17, 2024

Removed vultr server and associated DNS entries

Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching!

@ianjon3s ianjon3s merged commit 657bcf0 into main May 17, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/fix-address-loading-alignment branch May 17, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants