fix: Fetch flow settings in new views #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a small fix / refactor I noticed when working on #3183. It was introduced in #3028.
This work in also included in the WIP PR #3183 - once this PR is merged I'll rebase that one to pick up the changes. I've pulled it out into its own PR to make it easier to test & review.
Problem
The new pages (e.g.
/:flow/service) aren't correctly fetching team settings - this was only being done in/:flow/settings/:tab).Solution
A shared function,
getFlowSettings(), to handle this across routes in a consistent manner.Testing
To test this works as expected, you should be able to view and edit settings for a flow via both routes. You'll need the
EDITOR_NAVIGATIONfeature flag to do this (window.featureFlags.toggle("EDITOR_NAVIGATION"))