Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add new flow.status column to sync script #3192

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

DafyddLlyr
Copy link
Contributor

This PR adds the flows.status column to our sync script which was added in #3170

Tested locally with pnpm test-sync command ✅

@DafyddLlyr DafyddLlyr requested a review from a team May 24, 2024 10:33
@RODO94
Copy link
Contributor

RODO94 commented May 24, 2024

@DafyddLlyr how significant are the check errors for Vultr? And how do I access the pizza?

@DafyddLlyr
Copy link
Contributor Author

@RODO94 This PR is currently failing for the reasons outlined here - https://opensystemslab.slack.com/archives/C01E3AC0C03/p1716548233407109 (OSL Slack)

As this is holding you up from getting data locally you have a few options here -

  • You could checkout this branch locally, sync data, then carry on working on your branch
  • You could git cherry-pick this commit into your branch, sync data, and carry on. When we merge / rebase your branch, this cherry picked commit will be removed by git as it will already be on the target branch 🍒

@DafyddLlyr DafyddLlyr force-pushed the dp/sync-flows-status branch from 5724666 to 7b4f011 Compare May 24, 2024 12:21
@jessicamcinchak
Copy link
Member

@DafyddLlyr I've removed instance 3192 from vultr & fix is on main, so if you rebase to main here & push vultr should build fresh & succeed here for you on next go 🤞

@DafyddLlyr
Copy link
Contributor Author

Perfect thank you @jessicamcinchak 🙌

Copy link

github-actions bot commented May 24, 2024

Removed vultr server and associated DNS entries

Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it runs fine, I can now see the database data.

@DafyddLlyr DafyddLlyr merged commit 3881055 into main May 24, 2024
12 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/sync-flows-status branch May 24, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants