-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Restrict access to "offline" flows #3196
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43a4139
chore: Restrict public access to offline flows
DafyddLlyr 95235e6
test(e2e): Update tests to account for flow status
DafyddLlyr d1456b6
revert: Restrictions on flow.status via Hasura permissions
DafyddLlyr 4efcdac
feat: Route to offline page based on flow status
DafyddLlyr 3bd1049
feat: Allow users to complete S&R on offline flows
DafyddLlyr 587de80
fix: Handle S&R by adding layout wrapper
DafyddLlyr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import Typography from "@mui/material/Typography"; | ||
import StatusPage from "pages/Preview/StatusPage"; | ||
import React from "react"; | ||
|
||
export const OfflinePage: React.FC = () => ( | ||
<StatusPage bannerHeading="Offline"> | ||
<Typography variant="body2"> | ||
This service is not currently available to new applicants. Please check | ||
back later. | ||
</Typography> | ||
<Typography variant="body2"> | ||
If you're resuming an application you previously started, please use the | ||
link sent to you via email. | ||
</Typography> | ||
</StatusPage> | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import { useStore } from "pages/FlowEditor/lib/store"; | ||
import { OfflinePage } from "pages/OfflinePage"; | ||
import React, { PropsWithChildren } from "react"; | ||
|
||
const OfflineLayout = ({ children }: PropsWithChildren) => { | ||
const isFlowOnline = useStore.getState().flowStatus === "online"; | ||
const searchParams = new URLSearchParams(window.location.search); | ||
const isUserResuming = Boolean(searchParams.get("sessionId")); | ||
|
||
// Allow users to complete Save & Return journeys, even if a flow is offline | ||
const isFlowAccessible = isFlowOnline || isUserResuming; | ||
|
||
return isFlowAccessible ? children : <OfflinePage />; | ||
}; | ||
|
||
export default OfflineLayout; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clear solution ➕