Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all maps are referencing same container #3199

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: ensure all maps are referencing same container #3199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions editor.planx.uk/src/@planx/components/PropertyInformation/Public.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import React from "react";
import type { SiteAddress } from "../FindProperty/model";
import { FETCH_BLPU_CODES } from "../FindProperty/Public";
import { ErrorSummaryContainer } from "../shared/Preview/ErrorSummaryContainer";
import { MapContainer } from "../shared/Preview/MapContainer";
import type { PropertyInformation } from "./model";

export default Component;
Expand Down Expand Up @@ -79,16 +80,6 @@ export interface PresentationalProps {
handleSubmit?: handleSubmit;
}

const MapContainer = styled(Box)(({ theme }) => ({
padding: theme.spacing(1, 0),
width: "100%",
maxWidth: "none",
"& my-map": {
width: "100%",
height: "60vh",
},
}));

// Export this component for testing visual presentation with mocked props
export function Presentational(props: PresentationalProps) {
const {
Expand All @@ -103,7 +94,11 @@ export function Presentational(props: PresentationalProps) {
overrideAnswer,
handleSubmit,
} = props;
const teamName = useStore((state) => state.teamName);
const [teamName, environment] = useStore((state) => [
state.teamName,
state.previewEnvironment,
]);

const propertyDetails: PropertyDetail[] = [
{
heading: "Address",
Expand Down Expand Up @@ -131,7 +126,7 @@ export function Presentational(props: PresentationalProps) {
return (
<Card handleSubmit={handleSubmit}>
<CardHeader title={title} description={description} />
<MapContainer>
<MapContainer environment={environment}>
<p style={visuallyHidden}>
A static map centred on the property address, showing the title
boundary, often called the "blue-line" boundary in planning, of your
Expand Down
Loading