-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): Remove placeholders in DateInput
#3207
Conversation
88c1aa9
to
031c2ea
Compare
Removed vultr server and associated DNS entries |
031c2ea
to
0be7ddf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Year | ||
</Label> | ||
<Input | ||
value={year || ""} | ||
placeholder="YYYY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very happy to remove placeholders here, but should we also flag to content team that any DateInput components should now have descriptions like "For example, 23 4 2005" ?
Noticed all the GDS examples have this and I wonder if it's how to get a better "usability" score in the absense of official placeholders? https://design-system.service.gov.uk/components/date-input/
Merged as we've sent across the email to DAC! |
This is the only public facing placeholder in PlanX - all others are in the Editor. To meet the requirements set out in the report, we'd need to increase font size to 18pt which is a fair bit bigger than the current size.
Removing placeholder text also meets the GDS recommendation, as well as the pattern currently used in their Date Input components -