Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allows users to override inaccurate planning constraints #3216

Closed
wants to merge 5 commits into from

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented May 30, 2024

Begins to incorporate design feedback from call, replaces #3201 (links to a filtered, centered Planning Data map instead of rendering our own per constraint).

Lots of new questions! So many links & actions to contend with inside of accordions.

Outstanding tasks here if someone else picks up before 27 June:

  • Finalise UI
    • Show links to centred, filtered Planning Data maps for any constraint
    • Move Planning Data into "More information" per constraint (similar to Upload & Label help text pattern?)
    • Show override/change links per entity for intersecting constraints only (because changing a negative constraint to positive would require user to give details about specific entity for valid ODP Schema payload, and all adjoining constraint examples are based on "false positives")
    • Show input box like "Tell us why" if changing? or Confirm button?
  • Wireup UI to store override value onSubmit
    • Keep existing _constraints passport var to reflect "original"/"auditable" Planning Data response (this does not power future automations)
    • If you change all of the entities within a single positive constraint category, that value needs to be removed from property.constraints.planning and added to _nots: { property.constraints.planning... } (unless granular A4)
    • If you only change one of many entities within a single positive constraint category, property.constraints.planning & _nots should stay the same (unless granular A4)
    • Add a new internal passport variable like _overrides: { property.constraints.planning... } to record the specific Planning Data entity IDs that were overriden
    • Test that auto-answers work as expected
  • Add override data to ODP Schema payloads & update passport-mappings to populate
    • We don't currently share override info in the ODP Schema (for property.type or property.constraints.planning)
  • Open for PO testing (can happen in parallel to final payload step)
  • [Nice to have] Analytics tracking on override/change?
  • [Nice to have] Slack log or feedback loop to council GIS teams?

Copy link

github-actions bot commented May 30, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak
Copy link
Member Author

Closing this one in favor of #3432. Will transfer checklist to Trello ticket instead ✔️

@jessicamcinchak jessicamcinchak deleted the jess/override-constraints-no-map branch July 16, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant