Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: List component - submission and back navigation #3220

Merged
merged 3 commits into from
Jun 3, 2024
Merged

feat: List component - submission and back navigation #3220

merged 3 commits into from
Jun 3, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented May 31, 2024 •
edited
Loading

What does this PR do?

  • Submits validated form values via handleSubmit()
    • This adds the values to the passport and breadcrumbs
    • I don't think that what's in this PR is necessarily the right or final shape of this data, but this just serves to complete the wiring up of this component
  • Pre-populate form values on "back" navigation
  • Replaces brittle and repetitive test selectors with data-testid values (see feat: Basic CRUD for userData structure, setup ListContext #3198 (comment))

@DafyddLlyr DafyddLlyr mentioned this pull request May 31, 2024
Merged
6 tasks
@DafyddLlyr DafyddLlyr marked this pull request as ready for review May 31, 2024 21:27
@DafyddLlyr DafyddLlyr requested a review from a team May 31, 2024 21:28
@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@DafyddLlyr DafyddLlyr force-pushed the dp/list-component-form-values branch from a8fac56 to 0c3cce6 Compare June 1, 2024 08:59
@DafyddLlyr DafyddLlyr force-pushed the dp/list-submission-and-back branch from 81bfcbb to d529e74 Compare June 1, 2024 09:00
jessicamcinchak
jessicamcinchak approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jessicamcinchak jessicamcinchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for initial wire-up - this all looks good !

@jessicamcinchak jessicamcinchak merged commit be9b2d5 into dp/list-component-form-values Jun 3, 2024
10 checks passed
@jessicamcinchak jessicamcinchak deleted the dp/list-submission-and-back branch June 3, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jessicamcinchak