feat: Add Proposed Advertisements to List component and schema #3261
Conversation
Added advertisement schema.
Added schema selection for proposed advertisements
|
Removed vultr server and associated DNS entries |
| }, | ||
| }, | ||
| ], | ||
| min: 0, |
There was a problem hiding this comment.
nit: when min: 0, the component actually confusing loads like this - so we probably really want min: 1 ?
if we want it to be possible to "continue" without submitting any items, maybe there's a better way we can control that in the Editor modal using a simple toggle rather than in the schema via min ?
There was a problem hiding this comment.
Thanks, I misunderstood what was being set by min and max. Looks like min: 0 isn't even possible, as it throws this when you try to add any item:
| import { Schema } from "@planx/components/List/model"; | ||
|
|
||
| export const ProposedAdvertisements: Schema = { | ||
| type: "Proposed advertisements", |
There was a problem hiding this comment.
nit: this piece of text will be read into the title of each item & the "+ Add another ..." button - so it's actually best if it's singular rather than plural !
There was a problem hiding this comment.
Thanks, I actually want only one fixed input without the ability to add additional list items, so I will try min: 1, max: 1.
Added Proposed Advertisements schema and added it to the list component.