Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: when List schema sets max: 1, don't display add another button or index in card header #3265

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jun 11, 2024

Changes:

  • Re-organises all "test" schemas and their mocks for unit tests into a subfolder
  • Hides the "+ Add another" & card header index if the schema sets max: 1 ; always displays when max > 1 or undefined, or if there is no user data (eg max is 1, but first item is "cancelled" before any input, then "removed").

See new "Proposed advertisements" schema as example use case & feedback from August: https://opensystemslab.slack.com/archives/C5Q59R3HB/p1718050782075389?thread_ts=1717416055.509189&cid=C5Q59R3HB

Screenshot from 2024-06-11 11-59-42

@jessicamcinchak jessicamcinchak requested a review from a team June 11, 2024 11:39
@jessicamcinchak jessicamcinchak marked this pull request as ready for review June 11, 2024 11:39
Copy link

github-actions bot commented Jun 11, 2024

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit f936014 into main Jun 12, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/list-max-1 branch June 12, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant