Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop "LIST_COMPONENT" feature flag #3269

Merged
merged 1 commit into from
Jun 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions editor.planx.uk/src/lib/featureFlags.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// add/edit/remove feature flags in array below
const AVAILABLE_FEATURE_FLAGS = [
"EDITOR_NAVIGATION",
"LIST_COMPONENT",
] as const;
const AVAILABLE_FEATURE_FLAGS = ["EDITOR_NAVIGATION"] as const;

type FeatureFlag = (typeof AVAILABLE_FEATURE_FLAGS)[number];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ const NodeTypeSelect: React.FC<{
<option value={TYPES.DateInput}>Date Input</option>
<option value={TYPES.AddressInput}>Address Input</option>
<option value={TYPES.ContactInput}>Contact Input</option>
{hasFeatureFlag("LIST_COMPONENT") && (
<option value={TYPES.List}>List</option>
)}
<option value={TYPES.List}>List</option>
</optgroup>
<optgroup label="Information">
<option value={TYPES.TaskList}>Task List</option>
Expand Down
2 changes: 1 addition & 1 deletion editor.planx.uk/src/pages/Preview/Node.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ const Node: React.FC<any> = (props: Props) => {
return <FindProperty {...allProps} />;

case TYPES.List:
return hasFeatureFlag("LIST_COMPONENT") ? <List {...allProps} /> : null;
return <List {...allProps} />;

case TYPES.NextSteps:
return <NextSteps {...allProps} />;
Expand Down
Loading