Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow dot notation of fn values in List component schemas #3282

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 18, 2024

What does this PR do?

Copy link

github-actions bot commented Jun 18, 2024

Removed vultr server and associated DNS entries

@@ -49,7 +49,7 @@ export const TextFieldInput: React.FC<Props<TextField>> = ({
rows={
data.type && ["long", "extraLong"].includes(data.type) ? 5 : undefined
}
name={`userData[${activeIndex}][${data.fn}]`}
name={`userData[${activeIndex}]['${data.fn}']`}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is a bit weird / complex, but it's what Formik requires! Docs: https://formik.org/docs/guides/arrays#avoid-nesting

@DafyddLlyr DafyddLlyr requested a review from a team June 18, 2024 09:56
@DafyddLlyr DafyddLlyr marked this pull request as ready for review June 18, 2024 09:56
Copy link
Contributor

@ianjon3s ianjon3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values have been consistently replaced with .

@DafyddLlyr DafyddLlyr merged commit e3fb93e into main Jun 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants