chore: Make flow.name column required
#3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
commented
Jun 19, 2024
Comment on lines
+84
to
+85
| "INSERT INTO flows (id, slug, name) VALUES ($1, $2, $3) ON CONFLICT DO NOTHING", | ||
| [id, id, id], |
There was a problem hiding this comment.
This was an interesting one - without this I could create a flow, but not update it via ShareDB without an error.
I actually think this like of SQL will never get truly executed (it will always hit the ON CONFLICT clause). This is because the flow is created via Hasura prior to any ShareDB interaction takes place. Postgres must just be "clever enough" to know that this query is incorrect without a name value, despite it never actually being executed. This is why id, id, id is ok as these values are never actually read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
flow.namecolumn, this has now been updated to be a required field in the DB, which matches the associated types and expected behaviourflow.nameNext steps (?)
The reason there's so much "whack-a-mole" with some of these tests is that
flow.nameandflow.team_idare now really the compound primary key / unique constraints, notflow.slugandflow.team_id. A more robust solution may be to make this change in reality in the database, and to correspondingly update mocks to just have aflow.namevalue.Regression tests passing here - https://github.com/theopensystemslab/planx-new/actions/runs/9565438594 ✅