Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Maintain redirect on login #3302

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: Maintain redirect on login #3302

merged 1 commit into from
Jun 20, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jun 20, 2024

Alternate approach to #3275 where I'm running afoul of https://github.com/theopensystemslab/planx-new/security/code-scanning/17

Here's we're simply navigating back after a login to pickup the previous redirectTo params 👍

Copy link

github-actions bot commented Jun 20, 2024

Removed vultr server and associated DNS entries

@DafyddLlyr
Copy link
Contributor Author

@DafyddLlyr DafyddLlyr marked this pull request as ready for review June 20, 2024 12:53
Copy link
Contributor

@RODO94 RODO94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with:

link to team

link to flow

Both worked for me

@DafyddLlyr DafyddLlyr merged commit dd70f91 into main Jun 20, 2024
12 checks passed
RODO94 pushed a commit that referenced this pull request Jun 20, 2024
freemvmt added a commit that referenced this pull request Jul 12, 2024
freemvmt added a commit that referenced this pull request Jul 12, 2024
freemvmt added a commit that referenced this pull request Jul 18, 2024
freemvmt added a commit that referenced this pull request Jul 18, 2024
DafyddLlyr pushed a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants