chore: Make SettingsForm shared and generic
#3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jun 20, 2024
| import InputLegend from "ui/editor/InputLegend"; | ||
| import ErrorWrapper from "ui/shared/ErrorWrapper"; | ||
|
|
||
| type SettingsFormProps<TFormikValues> = { |
There was a problem hiding this comment.
Here's the core difference in this PR.
The previous props took a hardcoded TeamTheme, we're now using a generic type here.
DafyddLlyr
commented
Jun 20, 2024
| preview?: React.ReactElement; | ||
| }; | ||
|
|
||
| export const SettingsForm = <TFormikValues,>({ |
There was a problem hiding this comment.
Apart from changes to types and an update of the ErrorWrapper id, this component is copy/pasted from /DesignSettings/index.tsx
|
@RODO94 Once CI is done I'll merge to |
|
Removed vultr server and associated DNS entries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SettingsFormto a shared location so that it can be used outside the context of design settingsTeamTheme